Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: directory name ending with extention are not prepended with ext … #973

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: directory name ending with extention are not prepended with ext … #973

wants to merge 4 commits into from

Conversation

atamakahere-git
Copy link
Contributor

Tried fixing #965

TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@muniu-bot Muniu Bot
Copy link

muniu-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atamakahere-git

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the size/S label Dec 27, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.54%. Comparing base (ee2d12b) to head (f4041c4).

❗ Current head f4041c4 differs from pull request most recent head 0bad9f3. Consider uploading reports for the commit 0bad9f3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   84.34%   84.54%   +0.19%     
==========================================
  Files          53       51       -2     
  Lines        5111     5078      -33     
==========================================
- Hits         4311     4293      -18     
+ Misses        800      785      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarterLi
Copy link

In macOS, directores with extensions do have special meanings. For example, /Applications/Google Chrome.app, /System/Library/System.framework

@atamakahere-git
Copy link
Contributor Author

I will do some research/tests and get back on this, If any suggestion let me know.

@muniu-bot muniu-bot bot added size/L and removed size/S labels Jan 2, 2024
@muniu-bot muniu-bot bot added size/M and removed size/L labels Jan 2, 2024
@atamakahere-git
Copy link
Contributor Author

@CarterLi Hey, I did some changes that exclude special named directory.

@atamakahere-git
Copy link
Contributor Author

@zwpaper Hey, are you thinking of adding this enhancement to lsd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meain meain Awaiting requested review from meain

@Peltoche Peltoche Awaiting requested review from Peltoche

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atamakahere-git @CarterLi